Skip to content

Conversation

@JaredforReal
Copy link
Collaborator

What type of PR is this?
FIX: Upgrade docker/README.md with docker compose V2 quick start guide

What this PR does / why we need it:
Upgrade Docker Compose V1, which is deprecated, to V2 to avoid unexpected bugs.
Add some troubleshooting based on practice.

Which issue(s) this PR fixes:

Fixes #180

@netlify
Copy link

netlify bot commented Sep 20, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit d3ebe32
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68ce55c8b24edc0007d6aaef
😎 Deploy Preview https://deploy-preview-181--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Sep 20, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 website

Owners: @Xunzhuo
Files changed:

  • website/docs/getting-started/docker-quickstart.md
  • website/sidebars.js

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you directly move this to docs site

@JaredforReal
Copy link
Collaborator Author

@Xunzhuo sure

Signed-off-by: JaredforReal <[email protected]>
@Xunzhuo Xunzhuo changed the title FIX: Upgrade docker/README.md with docker compose V2 quick start guide docs: add docker compose quickstart Sep 20, 2025
@@ -0,0 +1,111 @@
# Docker Compose Quick Start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install with Docker Compose

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get this. Should I add an "Install Docker Compose V2" section in the doc?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i mean rename this title to Install with Docker Compose

Copy link
Collaborator Author

@JaredforReal JaredforReal Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got u now, but I think the "Install Docker Compose V2" section is worth keeping

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 20, 2025

/lgtm

@github-actions github-actions bot added the lgtm label Sep 20, 2025
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Xunzhuo Xunzhuo merged commit c6fa181 into vllm-project:main Sep 20, 2025
9 checks passed
@JaredforReal JaredforReal deleted the upgrade_docker branch September 22, 2025 02:48
yossiovadia pushed a commit to yossiovadia/semantic-router that referenced this pull request Oct 8, 2025
* upgrade docker/README.md with docker compose V2 quick start guide

Signed-off-by: JaredforReal <[email protected]>

* add docker-quickstart doc

Signed-off-by: JaredforReal <[email protected]>

* remove docker dir & rerank docker-quickstart in sidebar

Signed-off-by: JaredforReal <[email protected]>

* add install docker compose v2 section

Signed-off-by: JaredforReal <[email protected]>

* change title

Signed-off-by: JaredforReal <[email protected]>

---------

Signed-off-by: JaredforReal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Docker Compose V2 in Deployment

3 participants